Update activejob and sidekiq to +8 #94
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the gem to support ActiveJob 8.1 and Sidekiq 8.0, adds support for Ruby 3.3.6 and 3.4.1, and introduces Docker-based development infrastructure.
- Updated ActiveJob dependency constraint from
< 8.1to< 8.2 - Added support for Sidekiq 8.0's new wrapper class name (
Sidekiq::ActiveJob::Wrapper) - Added Ruby 3.3.6 and 3.4.1 to the CI test matrix
- Introduced Docker development environment with docker-compose and Makefile
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
lib/active_job/uniqueness/sidekiq_patch.rb |
Updated to recognize both old and new Sidekiq ActiveJob wrapper class names for compatibility with Sidekiq 8.x |
activejob-uniqueness.gemspec |
Bumped ActiveJob version constraint to support versions up to 8.2 |
gemfiles/sidekiq_8.x.gemfile |
Added gemfile for testing Sidekiq 8.x compatibility |
gemfiles/activejob_8.1.x.gemfile |
Added gemfile for testing ActiveJob 8.1 compatibility |
Appraisals |
Added appraisal definitions for ActiveJob 8.1.x and Sidekiq 8.x |
.github/workflows/main.yml |
Added Ruby 3.3.6 and 3.4.1 to test matrix, added new gemfiles, and expanded exclusion matrix (with some issues) |
Dockerfile |
Added Docker development environment using Ruby 3.2 |
docker-compose.yml |
Added service orchestration for Redis and the application |
Makefile |
Added convenience commands for Docker-based development workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - ruby: 3.4.1 | ||
| gemfile: gemfiles/sidekiq_8.x.gemfile | ||
|
|
There was a problem hiding this comment.
Incorrect exclusion of Sidekiq 8.x for Ruby 3.4.1. Sidekiq 8.0 supports Ruby 3.x, and excluding the newest Ruby version from testing with Sidekiq 8.x contradicts the purpose of adding Sidekiq 8 support. This exclusion should be removed to allow testing the combination.
| - ruby: 3.4.1 | |
| gemfile: gemfiles/sidekiq_8.x.gemfile |
| - gemfiles/activejob_7.1.x.gemfile | ||
| - gemfiles/activejob_7.2.x.gemfile | ||
| - gemfiles/activejob_8.0.x.gemfile | ||
| - gemfiles/activejob_8.1.x.gemfile |
There was a problem hiding this comment.
Missing exclusions for activejob_8.1.x.gemfile with incompatible Ruby versions. Based on the existing pattern where activejob_8.0.x is excluded for Ruby 2.5.9, 2.6.10, 2.7.7, 3.0.5, and 3.1.3, the same exclusions should be added for activejob_8.1.x to prevent CI failures with unsupported Ruby versions. ActiveJob 8.x typically requires Ruby 3.2+.
| - ruby: 3.3.6 | ||
| gemfile: gemfiles/sidekiq_5.x.gemfile | ||
| - ruby: 3.3.6 | ||
| gemfile: gemfiles/sidekiq_8.x.gemfile |
There was a problem hiding this comment.
Incorrect exclusion of Sidekiq 8.x for Ruby 3.3.6. Sidekiq 8.0 supports Ruby 3.x, and excluding newer Ruby versions from testing with Sidekiq 8.x contradicts the purpose of adding Sidekiq 8 support. This exclusion should be removed to allow testing the combination.
| gemfile: gemfiles/sidekiq_8.x.gemfile |
|
Hi - I forked this repository and published a new gem with rails 8.1 and sidekiq 8 support nordinvestments/activejob-uniqueness#4 Me and @viralpraxis will keep it maintained going forward Here is the new gem if anyone is interested https://rubygems.org/gems/activejob-unique Thanks :) |
1 participant
No description provided.