Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix publish workflow permissions #21773

Merged

Conversation

bthuilot
Copy link
Contributor

Summary

Fixes workflow permission for publish

Change Type

  • Non-functional (chore, refactoring, docs)

Is this a breaking change?

  • No

@bthuilot bthuilot requested a review from a team as a code owner November 12, 2024 22:10
@pront pront changed the title ci(github-actions): fix publish workflow permissions fix(ci): fix publish workflow permissions Nov 12, 2024
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Nov 12, 2024
@pront pront enabled auto-merge November 12, 2024 22:12
auto-merge was automatically disabled November 12, 2024 22:22

Head branch was pushed to by a user without write access

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to test this branch, but we currently have workflows set to readonly so it ran into that. We'll have to test after re-enabling.

Screenshot 2024-11-12 at 5 25 25 PM

@jszwedko
Copy link
Member

Or perhaps we need to add these permissions to workflows that call this one like https://github.com/vectordotdev/vector/blob/master/.github/workflows/custom_builds.yml

@bthuilot
Copy link
Contributor Author

@jszwedko updated custom_build.yml because i think that will require it too

@jszwedko
Copy link
Member

@jszwedko updated custom_build.yml because i think that will require it too

Thanks! I added it to the others that call publish.yml in 2cc7bf4

@jszwedko
Copy link
Member

@pront
Copy link
Contributor

pront commented Nov 13, 2024

@jszwedko jszwedko added this pull request to the merge queue Nov 13, 2024
Merged via the queue into vectordotdev:master with commit ca05055 Nov 13, 2024
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants