Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix symbol error #21294

Merged
merged 1 commit into from
Sep 16, 2024
Merged

chore: fix symbol error #21294

merged 1 commit into from
Sep 16, 2024

Conversation

liangmulu
Copy link
Contributor

No description provided.

Signed-off-by: liangmulu <[email protected]>
@liangmulu liangmulu requested a review from a team as a code owner September 13, 2024 16:23
@bits-bot
Copy link

bits-bot commented Sep 13, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liangmulu!

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Sep 13, 2024
@pront pront added this pull request to the merge queue Sep 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 16, 2024
Copy link

Regression Detector Results

Run ID: 80ce040e-bc59-4cc8-a59f-ff9321f50d0d Metrics dashboard

Baseline: f5b9265
Comparison: 3969a38

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI links
file_to_blackhole egress throughput +24.69 [+17.22, +32.17]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
file_to_blackhole egress throughput +24.69 [+17.22, +32.17]
syslog_log2metric_splunk_hec_metrics ingress throughput +3.30 [+3.17, +3.43]
datadog_agent_remap_blackhole_acks ingress throughput +3.17 [+3.03, +3.31]
syslog_regex_logs2metric_ddmetrics ingress throughput +2.13 [+1.94, +2.31]
syslog_humio_logs ingress throughput +0.42 [+0.31, +0.54]
socket_to_socket_blackhole ingress throughput +0.41 [+0.34, +0.48]
http_to_s3 ingress throughput +0.36 [+0.09, +0.64]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.36 [+0.15, +0.57]
fluent_elasticsearch ingress throughput +0.22 [-0.27, +0.71]
http_to_http_noack ingress throughput +0.16 [+0.08, +0.24]
datadog_agent_remap_blackhole ingress throughput +0.07 [-0.03, +0.17]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +0.07 [-0.04, +0.18]
http_to_http_json ingress throughput +0.04 [+0.00, +0.08]
splunk_hec_to_splunk_hec_logs_noack ingress throughput +0.02 [-0.08, +0.11]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.11, +0.10]
splunk_hec_indexer_ack_blackhole ingress throughput -0.01 [-0.09, +0.07]
http_text_to_http_json ingress throughput -0.02 [-0.13, +0.09]
otlp_http_to_blackhole ingress throughput -0.20 [-0.32, -0.08]
syslog_splunk_hec_logs ingress throughput -0.27 [-0.36, -0.17]
splunk_hec_route_s3 ingress throughput -0.35 [-0.66, -0.03]
datadog_agent_remap_datadog_logs ingress throughput -0.51 [-0.70, -0.33]
otlp_grpc_to_blackhole ingress throughput -0.55 [-0.66, -0.44]
http_to_http_acks ingress throughput -1.00 [-2.23, +0.23]
syslog_log2metric_humio_metrics ingress throughput -1.33 [-1.40, -1.26]
syslog_loki ingress throughput -1.65 [-1.79, -1.52]
http_elasticsearch ingress throughput -1.91 [-2.10, -1.72]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@jszwedko jszwedko added this pull request to the merge queue Sep 16, 2024
Copy link

Regression Detector Results

Run ID: f5e5400d-16b0-4624-a355-d1197485fc4c Metrics dashboard

Baseline: f5b9265
Comparison: 0291b64

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI links
file_to_blackhole egress throughput -0.88 [-8.23, +6.48]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
syslog_log2metric_splunk_hec_metrics ingress throughput +3.13 [+3.01, +3.25]
fluent_elasticsearch ingress throughput +1.94 [+1.45, +2.43]
splunk_hec_route_s3 ingress throughput +1.94 [+1.62, +2.26]
syslog_regex_logs2metric_ddmetrics ingress throughput +1.86 [+1.72, +2.01]
datadog_agent_remap_blackhole ingress throughput +0.92 [+0.82, +1.01]
syslog_log2metric_humio_metrics ingress throughput +0.81 [+0.69, +0.93]
otlp_grpc_to_blackhole ingress throughput +0.78 [+0.67, +0.88]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.72 [+0.52, +0.93]
http_to_s3 ingress throughput +0.67 [+0.40, +0.95]
syslog_loki ingress throughput +0.51 [+0.43, +0.58]
syslog_humio_logs ingress throughput +0.47 [+0.36, +0.59]
http_to_http_acks ingress throughput +0.20 [-1.02, +1.43]
http_to_http_noack ingress throughput +0.18 [+0.09, +0.26]
http_to_http_json ingress throughput +0.03 [-0.01, +0.08]
splunk_hec_indexer_ack_blackhole ingress throughput +0.01 [-0.07, +0.09]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.01 [-0.11, +0.12]
splunk_hec_to_splunk_hec_logs_noack ingress throughput +0.00 [-0.08, +0.09]
otlp_http_to_blackhole ingress throughput -0.19 [-0.31, -0.07]
socket_to_socket_blackhole ingress throughput -0.21 [-0.26, -0.16]
syslog_splunk_hec_logs ingress throughput -0.41 [-0.50, -0.32]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -0.45 [-0.53, -0.38]
file_to_blackhole egress throughput -0.88 [-8.23, +6.48]
datadog_agent_remap_datadog_logs ingress throughput -1.02 [-1.21, -0.82]
http_text_to_http_json ingress throughput -1.17 [-1.29, -1.05]
http_elasticsearch ingress throughput -1.19 [-1.37, -1.02]
datadog_agent_remap_blackhole_acks ingress throughput -1.84 [-1.97, -1.71]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into vectordotdev:master with commit 0291b64 Sep 16, 2024
67 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants