Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/x2earn rewards pool #19

Merged
merged 23 commits into from
Jul 23, 2024
Merged

Feat/x2earn rewards pool #19

merged 23 commits into from
Jul 23, 2024

Conversation

Agilulfo1820
Copy link
Member

  • Distribute rewards through X2EarnRewardsPool contract
  • Aligned contract logic to new distribution method
  • Mock VeBetterDAO contracts on solo / hardhat

@Agilulfo1820 Agilulfo1820 requested a review from a team as a code owner July 23, 2024 07:08
pierobassa
pierobassa reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@pierobassa pierobassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I'd also extend deployments to testnet too or add in the readme how to interact with existing testnet contracts through the dev environment

majority of devs go through testnet and not solo

apps/contracts/contracts/EcoEarn.sol Outdated Show resolved Hide resolved
apps/contracts/contracts/EcoEarn.sol Show resolved Hide resolved
@Agilulfo1820 Agilulfo1820 requested a review from pierobassa July 23, 2024 07:48
@Agilulfo1820 Agilulfo1820 merged commit 468105d into main Jul 23, 2024
3 checks passed
@pierobassa pierobassa deleted the feat/x2earn-rewards-pool branch July 23, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierobassa pierobassa pierobassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Agilulfo1820 @pierobassa