Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add greencart disclaimer #12

Closed

Conversation

rodolfopietro97
Copy link

Hi Team,

Following the recent discussion and the similarity observed with the Greencart DAPP use case, we propose adding a disclaimer to this repository. This disclaimer will help clarify the intended use and limitations of the content within the repo.

Thank you for your consideration.

@Valazan @fabiorigam @pierobassa @vineet-codes @bacco1977

@rodolfopietro97 rodolfopietro97 requested a review from a team as a code owner June 13, 2024 13:59
@pierobassa
Copy link
Member

image

Disclaimer should be coherent with the max width and centered.

Copy link
Member

@pierobassa pierobassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes to be made as suggested by @vineet-codes which make sense

  • Let's not use "Disclaimer" as wording but "Note".
  • Inspiration should not be only Greencart but Mugshot, Cleanify & Greencart as the template does inspire to all 3.

@Agilulfo1820
Copy link
Member

Can we style this disclaimer differently, maybe part of the footer? It seems more like an ad than a disclaimer

Copy link
Member

@akanoce akanoce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm personally NOT in favour of merging this.
As @pierobassa pointed out, all the apps are kinda inspired by each other, I find very silly to add such a claim, as it does not benefit the users of this app/repo in any way.

While it's true that the use case it's kinda similar, as @rodolfopietro97 stated this have been built without looking at greencart source code, hence i don't see any issue publishing this without any note or disclaimer.

If we follow this line, all the search engines should quote google, all the browsers should cite WorldWideWeb and so on. There is no such thing as a copyright on an use case or idea. Another thing is violation of copyright by copying the codebase, but this is clearly not the case.

@grenos
Copy link
Member

grenos commented Jun 20, 2024

I agrre with @akanoce. Such a banner doesn't add any value whatsoever to the template.

@pierobassa
Copy link
Member

Closing for stale over 2 weeks. Please re-open another PR if you deem it necessary

@pierobassa pierobassa closed this Jun 29, 2024
WillowMT added a commit to Tapple214/x-app-template that referenced this pull request Sep 14, 2024
* frontend: added routes

* frontend: added tailwind + package.json fix

* frontend: added login page

* frontend: login page fix

* profile page

* nav bar visible on /profile

* test pr

* scaffolding for dashboard page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants