You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[] Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
[] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[] This change requires a documentation update
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Run locally
Test Configuration:
Node.js Version:
Yarn Version:
Checklist:
My code follows the coding standards of this project
I have performed a self-review of my code
I have commented on my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
New and existing integration tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
I have not added any vulnerable dependencies to my code
The reason will be displayed to describe this comment to others. Learn more.
Currently we are duplicating the execution for the apps because they are included in workspaces in package.json. I created this ticket because of that #1500.
I would place this snippet either in a separate yml or (maybe) just get rid of the rest and use this file just for this test so you can also complete the other ticket. Otherwise this new part will be moved eventually.
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: I would try to use the normal import. Probably you are doing this because of the issue you described during these days, but I would double-check if you can somehow specify something in the playwright config to load this properly since it should not be required (basically you are saying something like "playwright, load ESM files").
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding playwright e2e tests to sample vite app
Fixes # 1515
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: