Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darren/feat/add transaction inputs #1517

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Darren/feat/add transaction inputs #1517

wants to merge 3 commits into from

Conversation

darrenvechain
Copy link
Member

Description

Enable delegation / comments and requested signer at the transaction level. This allows for fully integration with wallets.

Checklist:

  • My code follows the coding standards of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing integration tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@darrenvechain darrenvechain requested a review from a team as a code owner November 14, 2024 18:42
leszek-vechain
leszek-vechain reviewed Nov 15, 2024
View reviewed changes
...k/tests/signer/signers/vechain-private-key-signer/vechain-private-key-signer.testnet.test.ts
HexUInt.of(fixture.origin.privateKey).bytes,
new VeChainProvider(
thorClient,
THOR_SOLO_ACCOUNTS_BASE_WALLET,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question - we use solo wallet, but this is tesnet test is that right ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya it shouldn't matter, as the transaction is delegated below:

delegationUrl: fixture.options.delegatorUrl

@victhorbi victhorbi requested review from fabiorigam and a team and removed request for fabiorigam November 18, 2024 17:04
@victhorbi victhorbi mentioned this pull request Nov 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leszek-vechain leszek-vechain leszek-vechain left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darrenvechain @leszek-vechain @fabiorigam