Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue on error by default #387

Merged
merged 8 commits into from
Sep 25, 2022
Merged

Continue on error by default #387

merged 8 commits into from
Sep 25, 2022

Conversation

tony
Copy link
Member

@tony tony commented Sep 25, 2022

Fixes #363, related to #366

CLI sync:

  • Fix arguments on sub commands
  • Continue to next repo if encountering error when syncing
  • New flag: --exit-on-error / -x
  • Also stubs out basic CLI tests

@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Merging #387 (cf7d195) into master (ea44ca6) will increase coverage by 5.40%.
The diff coverage is 91.04%.

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
+ Coverage   80.17%   85.57%   +5.40%     
==========================================
  Files          15       15              
  Lines         787      846      +59     
  Branches      113      128      +15     
==========================================
+ Hits          631      724      +93     
+ Misses        130       89      -41     
- Partials       26       33       +7     
Impacted Files Coverage Δ
src/vcspull/log.py 68.42% <ø> (+38.59%) ⬆️
tests/conftest.py 98.73% <ø> (+5.06%) ⬆️
src/vcspull/cli/sync.py 58.75% <76.92%> (+12.37%) ⬆️
tests/test_cli.py 94.82% <94.44%> (+44.82%) ⬆️
src/vcspull/config.py 86.23% <0.00%> (+1.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony force-pushed the continue-on-error branch 2 times, most recently from 9fe85fa to b693cf1 Compare September 25, 2022 18:03
@tony tony force-pushed the continue-on-error branch from b693cf1 to 5bbb2bb Compare September 25, 2022 18:07
@tony tony force-pushed the continue-on-error branch from c93021e to de2e359 Compare September 25, 2022 18:43
@tony tony force-pushed the continue-on-error branch from de2e359 to cf7d195 Compare September 25, 2022 18:49
@tony tony merged commit fe453c1 into master Sep 25, 2022
@tony tony deleted the continue-on-error branch September 25, 2022 18:54
tony added a commit that referenced this pull request Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continue on error
1 participant