Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No URL found for submodules breaks the pull #366

Open
rogerioefonseca opened this issue Apr 8, 2022 · 5 comments
Open

No URL found for submodules breaks the pull #366

rogerioefonseca opened this issue Apr 8, 2022 · 5 comments
Labels

Comments

@rogerioefonseca
Copy link

Hello there,
While trying to use vcspull I noticed that it breaks and stops when a submodule is miss configured or does not exist.
Maybe would be better to validate the configuration and if it passes continue with the checkout and if not, warn the user and continue to checkout the next repo.

image

@aschleifer
Copy link
Contributor

there is a plan to do config validation in 2.0.0 as there will be a major config format rework done in that version.

@tony i guess submodule handling is entirely done in libvcs?

MfG
Andreas "Segaja" Schleifer

@tony tony added the bug label Apr 8, 2022
@tony tony added this to vcspull Apr 9, 2022
@tony
Copy link
Member

tony commented Apr 9, 2022

@rogerioefonseca @aschleifer

It is in the early stages, under the hood I am updating/untangling libvcs to address this.

  1. libvcs run() will support deferred execution and return a class so its more introspectable in tests and commands
  2. there will be a core Git command wrapper: feat(libvcs.cmd): Lite, typed, pythonic command wrappers for git, hg, mercurial libvcs#319
  3. there will be a way to continue_on_error that can pass directly through via the config (still not sure what the signature will look like)

@tony
Copy link
Member

tony commented Apr 11, 2022

Related: #363 continue on error

@tony
Copy link
Member

tony commented Sep 25, 2022

@rogerioefonseca I would need the full traceback of this to see the codepath where the exception was raised.

Sorry for the delay.

I can't quite recreate this exactly. I will make a PR where I've taken a stab

tony added a commit that referenced this issue Sep 25, 2022
Fixes #363, related to #366

CLI sync:
- Fix arguments on sub commands
- Continue to next repo if encountering error when syncing
- New flag: `--exit-on-error` / `-x`
- Also stubs out basic CLI tests
@tony
Copy link
Member

tony commented Sep 25, 2022

@rogerioefonseca I created #391, I can't recreate it, but had some test code out there that you can look at - which may be close to recreating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

3 participants