Get rid of windows.app as it's highly discouraged

manifest.json

@@ -1,7 +1,7 @@
 {
 	"id": "obsidian-contacts",
 	"name": "Contacts",
-	"version": "1.0.0",
+	"version": "1.0.1",
 	"minAppVersion": "0.15.0",
 	"description": "Allows you to manage and organize your contacts.",
 	"author": "Vadim Beskrovnov",

src/file/file.ts

@@ -1,10 +1,7 @@
-import { normalizePath, Notice, TFile, TFolder, Vault } from "obsidian";
+import { normalizePath, Notice, TFile, TFolder, Vault, Workspace } from "obsidian";
 import { join } from "path";
 
-const { vault } = window.app;
-
-export async function openFile(file: TFile) {
-  const { workspace } = window.app;
+export async function openFile(file: TFile, workspace: Workspace) {
   const leaf = workspace.getLeaf()
   await leaf.openFile(file, { active: true });
 }
@@ -19,14 +16,14 @@ export function findContactFiles(contactsFolder: TFolder) {
   return contactFiles;
 }
 
-export function createContactFile(folderPath: string) {
+export function createContactFile(folderPath: string, vault: Vault, workspace: Workspace) {
   const folder = vault.getAbstractFileByPath(folderPath)
   if (!folder) {
     new Notice(`Can not find path: '${folderPath}'. Please update "Contacts" plugin settings`);
     return;
   }
 
-  vault.create(normalizePath(join(folderPath, `Contact ${findNextFileNumber(folderPath)}.md`)), `
+  vault.create(normalizePath(join(folderPath, `Contact ${findNextFileNumber(folderPath, vault)}.md`)), `
 /---contact---/
 | key       | value |
 | --------- | ----- |
@@ -39,10 +36,10 @@ export function createContactFile(folderPath: string) {
 | Last chat |       |
 | Friends   |       |
 /---contact---/`)
-    .then(createdFile => openFile(createdFile));
+    .then(createdFile => openFile(createdFile, workspace));
 }
 
-function findNextFileNumber(folderPath: string) {
+function findNextFileNumber(folderPath: string, vault: Vault) {
   const folder = vault.getAbstractFileByPath(
     normalizePath(folderPath)
   ) as TFolder;

src/parse/parse.ts

@@ -1,19 +1,18 @@
-import { TFile } from "obsidian";
+import { TFile, Vault } from "obsidian";
 import { Contact } from "./contact";
 
-export async function parseContactFiles(files: TFile[]) {
+export async function parseContactFiles(files: TFile[], vault: Vault) {
   const contactsData: Contact[] = [];
   for (const contactFile of files) {
-    const contact = await parseContactData(contactFile);
+    const contact = await parseContactData(contactFile, vault);
     if (contact) {
       contactsData.push(contact);
     }
   }
   return contactsData;
 }
 
-async function parseContactData(file: TFile): Promise<Contact | null> {
-  const { vault } = window.app;
+async function parseContactData(file: TFile, vault: Vault): Promise<Contact | null> {
   const fileContents = await vault.cachedRead(file);
   if (!isContactFile(fileContents)) {
     return null;

src/ui/sidebar/components/ContactView.tsx

@@ -1,4 +1,5 @@
 import * as React from "react";
+import { useApp } from "src/context/hooks";
 import { openFile } from "src/file/file";
 import { Contact } from "src/parse/contact";
 import { daysUntilBirthday, diffDateToday } from "src/util/dates";
@@ -8,9 +9,13 @@ type ContactProps = {
 };
 
 export const ContactView = (props: ContactProps) => {
+	const { workspace } = useApp();
 	const contact = props.contact;
 	return (
-		<div className="contact-card" onClick={() => openFile(contact.file)}>
+		<div
+			className="contact-card"
+			onClick={() => openFile(contact.file, workspace)}
+		>
 			<div className="content">
 				<div className="name">
 					{contact.name} {contact.lastName}

src/ui/sidebar/components/SidebarRootView.tsx

@@ -14,7 +14,7 @@ type RootProps = {
 };
 
 export const SidebarRootView = (props: RootProps) => {
-	const { vault } = useApp();
+	const { vault, workspace } = useApp();
 	const [contacts, setContacts] = React.useState<Contact[]>([]);
 	const [sort, setSort] = React.useState<Sort>(Sort.LAST_CONTACT);
 	const folder = props.plugin.settings.contactsFolder;
@@ -30,7 +30,7 @@ export const SidebarRootView = (props: RootProps) => {
 
 		const contactFiles: TFile[] = findContactFiles(contactsFolder);
 
-		parseContactFiles(contactFiles).then((contactsData) =>
+		parseContactFiles(contactFiles, vault).then((contactsData) =>
 			setContacts(contactsData)
 		);
 	}, []);
@@ -39,7 +39,7 @@ export const SidebarRootView = (props: RootProps) => {
 		<div>
 			<HeaderView
 				onSortChange={setSort}
-				onCreateContact={() => createContactFile(folder)}
+				onCreateContact={() => createContactFile(folder, vault, workspace)}
 				sort={sort}
 			/>
 			<ContactsListView contacts={contacts} sort={sort} />

versions.json

@@ -1,3 +1,4 @@
 {
-	"1.0.0": "0.15.0"
-}
+	"1.0.0": "0.15.0",
+	"1.0.1": "0.15.0"
+}