Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and consolidate JCF #394

Merged
merged 9 commits into from
Nov 12, 2024
Merged

Update and consolidate JCF #394

merged 9 commits into from
Nov 12, 2024

Conversation

nickchristopher
Copy link
Contributor

@nickchristopher nickchristopher commented Oct 31, 2024

Description

These changes are for Joshua Control Facility (JCF) in ZLA.

EDW_APP and PMD_APP are two sectors/areas within JCF_APP.
This change:

  • Creates a new JCF folder
  • Updates the PMD boundary
  • Updates the EDW boundary
  • Adds a new combined JCF boundary
  • Deletes Boundaries/EDW and Boundaries/PMD

Motivation and Context

JCF_APP is a fairly new callsign and doesn't show any boundaries when online.
After this update, when JCF_APP is online, boundaries will cover both EDW_APP and PMD_APP.
When either EDW_APP or PMD_APP are online, boundaries will cover their own sectors within JCF.

How to prove the effect of this PR?

JCF_APP Combined
image

EDW_APP
image

PMD_APP
image

Airspace Diagrams from laartcc.org
image

Additional info

Is this a breaking change?

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My change or addition follow the formatting standard of the project.
  • I am on the list of approved contributors.

@nickchristopher nickchristopher changed the title Updates for JCF Update and consolidate JCF Oct 31, 2024
Copy link
Collaborator

@dirtyformal dirtyformal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your added files have a set of Features within a FeatureCollection, when they should be a singular Feature in each file.

Please change the files in your PR to conform to this requirement. Feel free to take a look at your old PMD.json and EDW.json files, which were compliant.

@dirtyformal
Copy link
Collaborator

Thanks, that's looking a lot better! Merging now.

@dirtyformal dirtyformal merged commit 3840fcd into vatsimnetwork:main Nov 12, 2024
2 checks passed
@nickchristopher nickchristopher deleted the JCF branch November 12, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants