Implement suggestions

vatsimnetwork · Oct 28, 2024 · c35a04f · c35a04f
1 parent a662997
commit c35a04f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/app/Http/Controllers/ClxMessagesController.php b/app/Http/Controllers/ClxMessagesController.php
@@ -100,7 +100,7 @@ public function showRclMessage(RclMessage $rclMessage)
 
         return view('controllers.clx.rcl-messages.show', [
             'message' => $rclMessage,
-            'dlAuthorities' => DatalinkAuthority::whereSystem(false)->get(),
+            'dlAuthorities' => DatalinkAuthority::notSystem()->get(),
             'tracks' => $rclMessage->is_concorde ? Track::concorde()->get() : Track::active()->get(),
             'activeDlAuthority' => $this->dataService->getActiveControllerAuthority(Auth::user()) ?? DatalinkAuthority::find('NAT'),
             '_pageTitle' => $rclMessage->callsign,

diff --git a/app/Models/DatalinkAuthority.php b/app/Models/DatalinkAuthority.php
@@ -2,6 +2,7 @@
 
 namespace App\Models;
 
+use Illuminate\Database\Eloquent\Builder;
 use Illuminate\Database\Eloquent\Model;
 
 /**
@@ -26,6 +27,7 @@
  * @method static \Illuminate\Database\Eloquent\Builder|DatalinkAuthority whereSystem($value)
  * @method static \Illuminate\Database\Eloquent\Builder|DatalinkAuthority whereUpdatedAt($value)
  * @method static \Illuminate\Database\Eloquent\Builder|DatalinkAuthority whereValidRclTarget($value)
+ * @method static Builder|DatalinkAuthority notSystem()
  * @mixin \Eloquent
  */
 class DatalinkAuthority extends Model
@@ -46,4 +48,9 @@ class DatalinkAuthority extends Model
     ];
 
     protected $keyType = 'string';
+
+    public function scopeNotSystem(Builder $query): Builder
+    {
+        return $query->where('system', false);
+    }
 }