Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-stack): update normal colors to info and add brand colors #8054

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OlivierFL
Copy link
Collaborator

Description

Following colors naming update in the design system, CSS variables have been updated accordingly:

  • rename --color-normal-* CSS variables to --color-info-*
  • add new --color-brand-* CSS variables

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

Copy link
Member

@MathieuRA MathieuRA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the info accent for components that use it and are on their latest version. For others, as we need to update them, I think these changes can be made at that time.

/* NORMAL */
/* BRAND */

--color-brand-txt-base: #9b92ff;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the DS, brand-txt-base for dark mode is: 6B63BF.
Probably an error in the DS?

Comment on lines +116 to +118
--color-brand-background-selected: color-mix(in srgb, #000000 70%, var(--color-brand-txt-base));
--color-brand-background-hover: color-mix(in srgb, #000000 60%, var(--color-brand-txt-base));
--color-brand-background-active: color-mix(in srgb, #000000 50%, var(--color-brand-txt-base));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--color-brand-background-selected: color-mix(in srgb, #000000 70%, var(--color-brand-txt-base));
--color-brand-background-hover: color-mix(in srgb, #000000 60%, var(--color-brand-txt-base));
--color-brand-background-active: color-mix(in srgb, #000000 50%, var(--color-brand-txt-base));
--color-brand-background-selected: color-mix(in srgb, #000000 90%, var(--color-brand-item-base));
--color-brand-background-hover: color-mix(in srgb, #000000 80%, var(--color-brand-item-base));
--color-brand-background-active: color-mix(in srgb, #000000 70%, var(--color-brand-item-base));

--color-brand-item-base: #8f84ff;
--color-brand-item-hover: color-mix(in srgb, #ffffff 20%, var(--color-brand-item-base));
--color-brand-item-active: color-mix(in srgb, #ffffff 40%, var(--color-brand-item-base));
--color-brand-item-disabled: #393566;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the DS, brand-txt-base for dark mode is: D2CEFF.
Probably an error in the DS?

Comment on lines +132 to +134
--color-info-background-selected: color-mix(in srgb, #000000 70%, var(--color-info-txt-base));
--color-info-background-hover: color-mix(in srgb, #000000 60%, var(--color-info-txt-base));
--color-info-background-active: color-mix(in srgb, #000000 50%, var(--color-info-txt-base));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--color-info-background-selected: color-mix(in srgb, #000000 70%, var(--color-info-txt-base));
--color-info-background-hover: color-mix(in srgb, #000000 60%, var(--color-info-txt-base));
--color-info-background-active: color-mix(in srgb, #000000 50%, var(--color-info-txt-base));
--color-info-background-selected: color-mix(in srgb, #000000 70%, var(--color-info-item-base));
--color-info-background-hover: color-mix(in srgb, #000000 60%, var(--color-info-item-base));
--color-info-background-active: color-mix(in srgb, #000000 50%, var(--color-info-item-base));

Comment on lines +49 to +50
--vts-counter--background-color: var(--color-info-item-base);
--vts-counter--color: var(--color-info-txt-item);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the accent info has been added in the DS for this component.
And that makes sense since we now have brand and info as color possibilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants