-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web-stack): update normal
colors to info
and add brand
colors
#8054
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the info
accent for components that use it and are on their latest version. For others, as we need to update them, I think these changes can be made at that time.
/* NORMAL */ | ||
/* BRAND */ | ||
|
||
--color-brand-txt-base: #9b92ff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the DS, brand-txt-base
for dark mode is: 6B63BF
.
Probably an error in the DS?
--color-brand-background-selected: color-mix(in srgb, #000000 70%, var(--color-brand-txt-base)); | ||
--color-brand-background-hover: color-mix(in srgb, #000000 60%, var(--color-brand-txt-base)); | ||
--color-brand-background-active: color-mix(in srgb, #000000 50%, var(--color-brand-txt-base)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--color-brand-background-selected: color-mix(in srgb, #000000 70%, var(--color-brand-txt-base)); | |
--color-brand-background-hover: color-mix(in srgb, #000000 60%, var(--color-brand-txt-base)); | |
--color-brand-background-active: color-mix(in srgb, #000000 50%, var(--color-brand-txt-base)); | |
--color-brand-background-selected: color-mix(in srgb, #000000 90%, var(--color-brand-item-base)); | |
--color-brand-background-hover: color-mix(in srgb, #000000 80%, var(--color-brand-item-base)); | |
--color-brand-background-active: color-mix(in srgb, #000000 70%, var(--color-brand-item-base)); |
--color-brand-item-base: #8f84ff; | ||
--color-brand-item-hover: color-mix(in srgb, #ffffff 20%, var(--color-brand-item-base)); | ||
--color-brand-item-active: color-mix(in srgb, #ffffff 40%, var(--color-brand-item-base)); | ||
--color-brand-item-disabled: #393566; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the DS, brand-txt-base
for dark mode is: D2CEFF
.
Probably an error in the DS?
--color-info-background-selected: color-mix(in srgb, #000000 70%, var(--color-info-txt-base)); | ||
--color-info-background-hover: color-mix(in srgb, #000000 60%, var(--color-info-txt-base)); | ||
--color-info-background-active: color-mix(in srgb, #000000 50%, var(--color-info-txt-base)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--color-info-background-selected: color-mix(in srgb, #000000 70%, var(--color-info-txt-base)); | |
--color-info-background-hover: color-mix(in srgb, #000000 60%, var(--color-info-txt-base)); | |
--color-info-background-active: color-mix(in srgb, #000000 50%, var(--color-info-txt-base)); | |
--color-info-background-selected: color-mix(in srgb, #000000 70%, var(--color-info-item-base)); | |
--color-info-background-hover: color-mix(in srgb, #000000 60%, var(--color-info-item-base)); | |
--color-info-background-active: color-mix(in srgb, #000000 50%, var(--color-info-item-base)); |
--vts-counter--background-color: var(--color-info-item-base); | ||
--vts-counter--color: var(--color-info-txt-item); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the accent info
has been added in the DS for this component.
And that makes sense since we now have brand
and info
as color possibilities.
Description
Following colors naming update in the design system, CSS variables have been updated accordingly:
--color-normal-*
CSS variables to--color-info-*
--color-brand-*
CSS variablesChecklist
Fixes #007
,See xoa-support#42
,See https://...
)Introduced by
CHANGELOG.unreleased.md
Review process
Notes: