array as parameter for dateMarker #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasturiano
reviewed
May 27, 2019
| ) { | ||
| for (var i = 0; i < state.dateMarker.length; i++) { | ||
|
|
||
| state.dateMarkerLine.push(state.svg.append('line').attr('class', 'x-axis-date-marker')); |
Owner
There was a problem hiding this comment.
Unfortunately this won't be able to react to changes in props. Every time the graph is re-rendered a new line will be added to the DOM. Similarly they will not be removed if the prop changes value. The maintenance of these objects should be done with an enter/update/exit d3 pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! There is array of dateMarker feature, please check