Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add repository for project, customer and organisation. Rename Database to Infrastructure #524

Merged
merged 9 commits into from
Oct 8, 2024
Merged

add repository for project, customer and organisation. Rename Database to Infrastructure #524

merged 9 commits into from
Oct 8, 2024

Conversation

jonasbjoralt
Copy link
Collaborator

@jonasbjoralt jonasbjoralt commented Oct 7, 2024 •
edited
Loading

Using Repository Pattern to get a simpler flow wrt. caching etc.

  • Changed one endpoint in ProjectController to use Repository
  • Added IRepository and Repository classes to access data

TODO: Add cached repositories as well

Would especially like some help with how to deal with relations

trulshj
trulshj approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@trulshj trulshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veldig riktig spor! Et par kommentarer med ting og tang så er det her 👨‍🍳👌

@trulshj trulshj self-requested a review October 7, 2024 12:27
trulshj
trulshj requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@trulshj trulshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@jonasbjoralt jonasbjoralt requested a review from trulshj October 7, 2024 13:02
trulshj
trulshj reviewed Oct 7, 2024
View reviewed changes
backend/Api/Program.cs Outdated Show resolved Hide resolved
trulshj
trulshj requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@trulshj trulshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veldig bra!

@jonasbjoralt jonasbjoralt requested a review from trulshj October 7, 2024 19:15
trulshj
trulshj requested changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@trulshj trulshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut det her! Eneste konkrete jeg ser som jeg ville fiksa er namespaces -> plural

backend/Core/Consultant/Consultant.cs Outdated Show resolved Hide resolved
backend/Core/Consultant/Consultant.cs Outdated Show resolved Hide resolved
trulshj
trulshj approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@trulshj trulshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@jonasbjoralt jonasbjoralt merged commit ec6f8b9 into main Oct 8, 2024
3 checks passed
@jonasbjoralt jonasbjoralt deleted the poc/repo-pattern branch October 8, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbrevik cbrevik cbrevik left review comments

@trulshj trulshj trulshj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonasbjoralt @cbrevik @trulshj