Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show and remove filter, change design #156

Merged
merged 11 commits into from
Oct 20, 2023
Merged

Show and remove filter, change design #156

merged 11 commits into from
Oct 20, 2023

Conversation

sigridge
Copy link
Contributor

No description provided.

@sigridge sigridge requested a review from jonasbjoralt October 19, 2023 13:25
Copy link
Collaborator

@jonasbjoralt jonasbjoralt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix: 0 -> Velg/velg bort alle
Fix: Gjør hele området klikkbart

async function getDepartments(setDepartments: Function, pathName: string) {
try {
const data = await fetch(
`${pathName}/api/departments?organisationName=${pathName.split("/")[1]}`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kanskje vi kan fikse dette senere, men dette er en ganske utrygg måte å hente org-id på, siden det er prisgitt at URL er bem.no//mer ting

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Svar: Fikser URL-håndtering senere

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er dette noe jeg kan hjelpe til med? :)

@yelodevopsi yelodevopsi added this to the Filtermeny ny milestone Oct 20, 2023
@yelodevopsi yelodevopsi added the enhancement New feature or request label Oct 20, 2023
async function getDepartments(setDepartments: Function, pathName: string) {
try {
const data = await fetch(
`${pathName}/api/departments?organisationName=${pathName.split("/")[1]}`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Svar: Fikser URL-håndtering senere

@sigridge sigridge merged commit 0f818e4 into main Oct 20, 2023
3 checks passed
@sigridge sigridge deleted the 142-more-filter branch October 20, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants