Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected typo on font-family + meta-data fix #152

Merged
merged 5 commits into from
Oct 19, 2023
Merged

Corrected typo on font-family + meta-data fix #152

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
069950d
Corrected typo on font-family
yelodevopsi Oct 19, 2023
1371551
Fixed next/head usage in Layout with metadata
yelodevopsi Oct 19, 2023
2d96cbe
Removing metadata since prettier wont accept it. No current need for …
yelodevopsi Oct 19, 2023
ea4fa0d
Removing import
yelodevopsi Oct 19, 2023
d7c7203
Re-adding next/head since warning apparently is gone?
yelodevopsi Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/app/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@

h1 {
font-size: 2rem;
font-family: "Recoletta-Regular";
font-family: "Recoleta-Regular";
line-height: 2.5rem;
}

Expand Down
8 changes: 0 additions & 8 deletions frontend/src/app/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import "./globals.css";
import Head from "next/head";
import NavBar from "@/components/NavBar/NavBar";

export default function RootLayout({
Expand All @@ -9,13 +8,6 @@ export default function RootLayout({
}) {
return (
<html>
<Head>
<title>Vibes Frontend</title>
<meta
name="viewport"
content="minimum-scale=1, initial-scale=1, width=device-width"
/>
</Head>
Copy link
Collaborator

@jonasbjoralt jonasbjoralt Oct 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hvorfor fjerner vi detta?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snodig... får ikke next/head warning i console lenger. Legger koden tilbake igjen nå.
Tidligere feil var:

✓ Compiled (160 modules)
Warning: You're using `next/head` inside the `app` directory, please migrate to the Metadata API. See https://nextjs.org/docs/app/building-your-application/upgrading/app-router-migration#step-3-migrating-nexthead for more details.
 ✓ Compiled /[organisation]/bemanning/page in 1614ms (1091 modules)

<body>
<NavBar />
{children}
Expand Down