Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

110 fix server side authentification #133

Merged
merged 21 commits into from
Oct 13, 2023
Merged

110 fix server side authentification #133

merged 21 commits into from
Oct 13, 2023

Conversation

jonasbjoralt
Copy link
Collaborator

@jonasbjoralt jonasbjoralt commented Oct 12, 2023 •
edited
Loading

Need to test how well this deploys first.
We currently deploy as a static web app, so maybe this session-voodoo-stuff breaks in Azure.

This is based off of Magnus' branch 110-fix-server-side-authentification but with some substansial modifications.

Notable things:

  • useQuery is removed
    • This greatly simplifies datafetching
  • Authentication is done via server session/cookie + auth-token stored on the server
  • When running locally, you might need to clear browser data for localhost:3000 etc

@jonasbjoralt jonasbjoralt changed the title (DONT MERGE) 110 fix server side authentification jb edition (DONT MERGE) 110 fix server side authentification Oct 12, 2023
@jonasbjoralt jonasbjoralt temporarily deployed to Development October 13, 2023 07:02 — with GitHub Actions Inactive
@sigridge sigridge temporarily deployed to Development October 13, 2023 08:23 — with GitHub Actions Inactive
@sigridge sigridge temporarily deployed to Development October 13, 2023 09:25 — with GitHub Actions Inactive
@jonasbjoralt jonasbjoralt temporarily deployed to Development October 13, 2023 09:30 — with GitHub Actions Inactive
@sigridge sigridge temporarily deployed to Development October 13, 2023 10:46 — with GitHub Actions Inactive
@jonasbjoralt jonasbjoralt temporarily deployed to Development October 13, 2023 11:16 — with GitHub Actions Inactive
@jonasbjoralt jonasbjoralt temporarily deployed to Development October 13, 2023 12:13 — with GitHub Actions Inactive
@jonasbjoralt jonasbjoralt temporarily deployed to Development October 13, 2023 12:16 — with GitHub Actions Inactive
@jonasbjoralt jonasbjoralt temporarily deployed to Development October 13, 2023 12:33 — with GitHub Actions Inactive
@jonasbjoralt jonasbjoralt marked this pull request as ready for review October 13, 2023 12:33
@jonasbjoralt jonasbjoralt changed the title (DONT MERGE) 110 fix server side authentification 110 fix server side authentification Oct 13, 2023
@jonasbjoralt jonasbjoralt merged commit ffab112 into main Oct 13, 2023
2 checks passed
@jonasbjoralt jonasbjoralt deleted the 110-fix-server-side-authentification-jb-edition branch October 13, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigridge sigridge sigridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonasbjoralt @sigridge