Renamed endpoints and variables in code to "consultant" for generic u…

…sage
varianter · Oct 16, 2023 · 9ade500 · 9ade500
1 parent 5121a98
commit 9ade500
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/backend/Api/Consultants/ConsultantController.cs b/backend/Api/Consultants/ConsultantController.cs
@@ -9,7 +9,7 @@
 
 namespace Api.Consultants;
 
-[Route("v0/variants")]
+[Route("v0/consultants")]
 [ApiController]
 public class ConsultantController : ControllerBase
 {
@@ -42,23 +42,23 @@ public ActionResult<List<ConsultantReadModel>> Get(
 
     [HttpPost]
     public async Task<Results<Created<ConsultantWriteModel>, ProblemHttpResult, ValidationProblem>> AddBasicConsultant(
-        [FromBody] ConsultantWriteModel basicVariant)
+        [FromBody] ConsultantWriteModel basicConsultant)
     {
         try
         {
-            var selectedDepartment = await GetDepartmentByIdAsync(basicVariant.DepartmentId);
+            var selectedDepartment = await GetDepartmentByIdAsync(basicConsultant.DepartmentId);
             if (selectedDepartment == null) return TypedResults.Problem("Department does not exist", statusCode: 400);
 
             var consultantList = await GetAllConsultantsAsync(_context);
-            var validationResults = ConsultantValidators.ValidateUniqueness(consultantList, basicVariant);
+            var validationResults = ConsultantValidators.ValidateUniqueness(consultantList, basicConsultant);
 
             if (validationResults.Count > 0) return TypedResults.ValidationProblem(validationResults);
 
-            var newConsultant = CreateConsultantFromModel(basicVariant, selectedDepartment);
+            var newConsultant = CreateConsultantFromModel(basicConsultant, selectedDepartment);
             await AddConsultantToDatabaseAsync(_context, newConsultant);
             ClearConsultantCache();
 
-            return TypedResults.Created($"/variant/{newConsultant.Id}", basicVariant);
+            return TypedResults.Created($"/consultant/{newConsultant.Id}", basicConsultant);
         }
         catch
         {
@@ -137,13 +137,13 @@ private static async Task<List<Consultant>> GetAllConsultantsAsync(ApplicationCo
         return await db.Consultant.ToListAsync();
     }
 
-    private static Consultant CreateConsultantFromModel(ConsultantWriteModel basicVariant,
+    private static Consultant CreateConsultantFromModel(ConsultantWriteModel basicConsultant,
         Department selectedDepartment)
     {
         return new Consultant
         {
-            Name = basicVariant.Name,
-            Email = basicVariant.Email,
+            Name = basicConsultant.Name,
+            Email = basicConsultant.Email,
             Department = selectedDepartment
         };
     }

diff --git a/frontend/src/app/bemanning/page.tsx b/frontend/src/app/bemanning/page.tsx
@@ -3,7 +3,7 @@ import { fetchWithToken } from "@/data/fetchWithToken";
 import { Variant } from "@/types";
 
 export default async function Bemanning() {
-  const consultants = (await fetchWithToken<Variant[]>("variants")) ?? [];
+  const consultants = (await fetchWithToken<Variant[]>("consultants")) ?? [];
 
   return (
     <div>

diff --git a/frontend/src/data/fetchWithToken.ts b/frontend/src/data/fetchWithToken.ts
@@ -32,7 +32,7 @@ export async function fetchWithToken<T>(path: string): Promise<T | undefined> {
 
 function mockedCall<T>(path: string): Promise<T> {
   return new Promise((resolve) => {
-    if (path.includes("variants")) {
+    if (path.includes("consultants")) {
       resolve(MockConsultants as T);
     }
     if (path.includes("departments")) {