Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup in defragEntryFinishCbForKeys #1562

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

nadav-levanoni
Copy link
Contributor

quick change

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.65%. Comparing base (d6a2f56) to head (2f1c49d).
Report is 1 commits behind head on 8.0.

Additional details and impacted files
@@            Coverage Diff             @@
##              8.0    #1562      +/-   ##
==========================================
+ Coverage   70.46%   70.65%   +0.18%     
==========================================
  Files         114      114              
  Lines       62947    62946       -1     
==========================================
+ Hits        44358    44474     +116     
+ Misses      18589    18472     -117     
Files with missing lines Coverage Δ
src/defrag.c 84.24% <100.00%> (-2.28%) ⬇️

... and 14 files with indirect coverage changes

@enjoy-binbin enjoy-binbin linked an issue Jan 15, 2025 that may be closed by this pull request
@enjoy-binbin enjoy-binbin changed the title clean-up defragEntryFinishCbForKeys Minor cleanup in defragEntryFinishCbForKeys Jan 15, 2025
@enjoy-binbin enjoy-binbin merged commit 1a34a4f into valkey-io:8.0 Jan 15, 2025
55 of 62 checks passed
@enjoy-binbin
Copy link
Member

oh shit, why this is targeting the 8.0 branch?

@enjoy-binbin
Copy link
Member

We generally reduce unnecessary changes / cleanup in the release branch, which makes it easier to resolve the conflicts and doing cheery-pick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small code clean-up in defrag 8.0
3 participants