Fix module LatencyAddSample still work when latency-monitor-threshold is 0 #1541
+40
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enjoy-binbin
force-pushed
the
fix_module_latency
branch
from
c13ce11 to
dd10fad
Compare
… is 0 When latency-monitor-threshold is set to 0, it means the latency monitor is disabled, and in VM_LatencyAddSample, we wrote the condition incorrectly, causing us to record latency when latency was turned off. Signed-off-by: Binbin <[email protected]>
enjoy-binbin
force-pushed
the
fix_module_latency
branch
from
dd10fad to
a901e64
Compare
|
Currently LATENCY LATEST only has the following fields:
I would also like to take it opportunity to discuss, if we can add more fields, like:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1541 +/- ##
============================================
+ Coverage 70.77% 70.95% +0.18%
============================================
Files 120 120
Lines 65005 65006 +1
============================================
+ Hits 46005 46124 +119
+ Misses 19000 18882 -118
|
PingXie
approved these changes
Jan 10, 2025
zuiderkwast
approved these changes
Jan 10, 2025
Day 1 bug introduced in 7.2.4 Redis: e3b1d6d3ad |
madolson
approved these changes
Jan 10, 2025
|
The PR was merged in 2019, it's a much older bug than that. |
madolson
reviewed
Jan 10, 2025
Comment on lines
+7683
to
+7684
| if (server.latency_monitor_threshold && latency >= server.latency_monitor_threshold) | ||
| latencyAddSample(event, latency); |
There was a problem hiding this comment.
Suggested change
| if (server.latency_monitor_threshold && latency >= server.latency_monitor_threshold) | |
| latencyAddSample(event, latency); | |
| latencyAddSampleIfNeeded(event, latency); |
Optional, I just noticed we have this helper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When latency-monitor-threshold is set to 0, it means the latency monitor
is disabled, and in VM_LatencyAddSample, we wrote the condition incorrectly,
causing us to record latency when latency was turned off.