Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set GH actions job timeout to a day #1540

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

hpatro
Copy link
Collaborator

@hpatro hpatro commented Jan 9, 2025

It's currently set to 14400 which is 10 days. I think we shouldn't leave jobs lingering around for that amount of period.

Signed-off-by: Harkrishn Patro <[email protected]>
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.93%. Comparing base (d99457c) to head (a4f5d77).

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1540      +/-   ##
============================================
- Coverage     70.94%   70.93%   -0.02%     
============================================
  Files           120      120              
  Lines         65004    65004              
============================================
- Hits          46116    46109       -7     
- Misses        18888    18895       +7     

see 12 files with indirect coverage changes

@enjoy-binbin
Copy link
Member

i somehow feel that one day is still quite long.

@hpatro
Copy link
Collaborator Author

hpatro commented Jan 10, 2025

i somehow feel that one day is still quite long.

Yes, I also feel so. Wasn't sure how long can jobs be under waiting state for GH action runners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants