refactor: move all valkey modules related declarations to module.h
#1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit we move all structures and functions declarations related to Valkey modules from `server.h` to the recently added `module.h` file. This re-organization makes it easier for new contributers to find the valkey modules related code, as well as reducing the compilation times when changes are made to the modules code. Signed-off-by: Ricardo Dias <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1489 +/- ##
============================================
- Coverage 70.86% 70.85% -0.02%
============================================
Files 119 119
Lines 64859 64864 +5
============================================
- Hits 45963 45958 -5
- Misses 18896 18906 +10
|
zuiderkwast
reviewed
Jan 2, 2025
Signed-off-by: Ricardo Dias <[email protected]>
zuiderkwast
reviewed
Jan 2, 2025
zuiderkwast
reviewed
Jan 2, 2025
Signed-off-by: Ricardo Dias <[email protected]>
zuiderkwast
approved these changes
Jan 2, 2025
|
Great, I merged so it doesn't block your next PR. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit we move all structures and functions declarations related to Valkey modules from
server.hto the recently addedmodule.hfile.This re-organization makes it easier for new contributers to find the valkey modules related code, as well as reducing the compilation times when changes are made to the modules code.
Signed-off-by: Ricardo Dias [email protected]