Check whether to switch to fail when setting the node to pfail in cron (

#1061) This may speed up the transition to the fail state a bit. Previously we would only check when we received a pfail/fail report from others in gossip. If myself is the last vote, we can directly switch to fail in here without waiting for the next gossip packet. Signed-off-by: Binbin <[email protected]>
valkey-io · Jan 6, 2025 · c0014ef · c0014ef
1 parent 33b8241
commit c0014ef
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/cluster_legacy.c b/src/cluster_legacy.c
@@ -5217,7 +5217,7 @@ void clusterCron(void) {
             if (!(node->flags & (CLUSTER_NODE_PFAIL | CLUSTER_NODE_FAIL))) {
                 node->flags |= CLUSTER_NODE_PFAIL;
                 update_state = 1;
-                if (server.cluster->size == 1 && clusterNodeIsVotingPrimary(myself)) {
+                if (clusterNodeIsVotingPrimary(myself)) {
                     markNodeAsFailingIfNeeded(node);
                 } else {
                     serverLog(LL_NOTICE, "NODE %.40s (%s) possibly failing.", node->name, node->human_nodename);