Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ping Xie <[email protected]>
Signed-off-by: zhaozhao.zz <[email protected]>
  • Loading branch information
soloestoy and PingXie authored Jan 21, 2025
1 parent 8df87ef commit 885a11c
Showing 1 changed file with 22 additions and 9 deletions.
31 changes: 22 additions & 9 deletions valkey.conf
Original file line number Diff line number Diff line change
Expand Up @@ -1975,15 +1975,28 @@ aof-timestamp-enabled no
# during server operation, including CPU, memory, and network bandwidth.
# These commands and the data they access may lead to abnormal instance operations,
# the commandlog can help users quickly and intuitively locate issues.
# Currently, there are three types of commandlogs supported: those used to record
# commands with long execution times, those with large requests, and those with
# large query replies.

# The first type is SLOW, log queries that exceeded a specified execution time.
# The execution time does not include the I/O operations like talking with the client,
# sending the reply and so forth, but just the time needed to actually execute the
# command (this is the only stage of command execution where the thread is blocked
# and can not serve other requests in the meantime).
#
# Currently, three types of command logs are supported:
#
# SLOW: Logs commands that exceed a specified execution time. This excludes time spent
# on I/O operations like client communication and focuses solely on the command's
# processing time, where the main thread is blocked.
#
# LARGE-REQUEST: Logs commands with requests exceeding a defined size. This helps
# identify potentially problematic commands that send excessive data to the server.
#
# LARGE-REPLY: Logs commands that generate replies exceeding a defined size. This
# helps identify commands that return unusually large amounts of data, which may
# impact network performance or client processing.
#
# Each log type has two key parameters:
# 1. A threshold value that determines when a command is logged. This threshold is specific
# to the type of log (e.g., execution time, request size, or reply size). A negative value disables
# logging. A value of 0 logs all commands.
# 2. A maximum length that specifies the number of entries to retain in the log. Increasing
# the length allows more entries to be stored but consumes additional memory. To clear all
# entries for a specific log type and reclaim memory, use the `COMMANDLOG RESET`
# subcommand followed by the log type.
#
# You can configure the slow threshold with two parameters: one tells the server
# what is the execution time, in microseconds, to exceed in order for the
Expand Down

0 comments on commit 885a11c

Please sign in to comment.