Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Requirements Version #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

carloselucio
Copy link

Summary 📝

Updated the requirements versions to avoid dependency conflicts between Valiot packages.

Fixes #SDLMICRO-396

Type of change 🦺

  • 💥MAJOR CHANGE: Fix or feature that can change the behaviour of a component or project. These changes also contain all the breaking changes.
  • MINOR CHANGE: Add new features or deprecate existing ones, all without breaking changes.
  • 🩹PATCH CHANGE: Can be a refactor of an existing component, a bug fix or the improvement of a new library, optimising existing features, adding notifications or stuff like that. It's not a big requirement or an algorithm required by the client, something that doesn't require a breaking change.

How has this been tested? ⚗️

How were these changes tested, and what changed?

Automatic tests Manual tests
  • With a CI tool
  • With an implementation
  • command_line
  • (...)
  • Using the terminal and vcos-test-worker
  • I changed Pipfile packages to install the local ones
  • I deleted my current environment with pipenv --rm
  • I created a new environment with pipenv shell and installed dependencies with pipenv install
  • I checked that everything was correct between dependencies using pipenv graph

Visual demo

Before (What happened before?) After (What happens now?)
Screen Shot 2022-02-23 at 9 43 23 image
Explanation of the previous behaviour. No conflicts found between package dependencies

Documentation 📖

If these changes require a documentation update, please report it on the corresponding channel of the Valiot official handbook.

Checklist 📋

Ensure all the below points are satisfied before opening a Pull Request for review. If they are not satisfied, you can always open it as draft.

  • 💻 My code follows the style guidelines of this project.
  • :octocat: I have performed a self-review of my code.
  • ⚠️ My code doesn't generate new warnings or alerts (deprecate code or incompatible libraries).
  • 🧪 New and existing tests pass successfully.
  • ✅ The checks pass successfully on my local machine.
  • 💯 My code is covered by tests.
  • 📓 Documentation and comments are added where needed.

@carloselucio carloselucio self-assigned this Mar 23, 2023
@carloselucio carloselucio added the dependencies Pull requests that update a dependency file label Mar 23, 2023
@carloselucio carloselucio marked this pull request as ready for review March 24, 2023 15:01
@EBKH EBKH added the ValueChainOS PRs related to ValueChainOS development label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ValueChainOS PRs related to ValueChainOS development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants