Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make non-exported symbols static in dllmain.c #2940

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

roflcopter4
Copy link

The PR I made last year was too big. I changed everything practically. Some changes were maybe valid, some not, but there were too many. So here's a little one that has mildly bothered me for months and months now. Nearly all of the (far too numerous) symbols in dllmain.c are not actually used outside that file. They can be static. I've made it so.

I also added void to a few function declarations with no parameters because I'm neurotic like that and renamed the variable Code to dllCode because it hurt me to look at, but I somehow avoided the urge to change anything else that might break something. So this shouldn't break anything, probably. Doesn't really fix anything either though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant