Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fbp 289 unique id validation #356

Merged
merged 3 commits into from
Jul 2, 2023

Conversation

valb3r
Copy link
Owner

@valb3r valb3r commented Jul 2, 2023

Fixes #289

@codecov-commenter
Copy link

Codecov Report

Merging #356 (df604ae) into master (bd10e37) will decrease coverage by 0.12%.
The diff coverage is 50.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##             master     #356      +/-   ##
============================================
- Coverage     64.06%   63.94%   -0.12%     
- Complexity     1356     1365       +9     
============================================
  Files           203      204       +1     
  Lines          7060     7106      +46     
  Branches        895      900       +5     
============================================
+ Hits           4523     4544      +21     
- Misses         2194     2216      +22     
- Partials        343      346       +3     
Flag Coverage Δ
unittests 63.94% <50.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ellij/plugin/core/ui/components/MultiEditJTable.kt 1.06% <0.00%> (-0.06%) ⬇️
...ij/plugin/core/properties/PropertyInputVerifier.kt 25.00% <25.00%> (ø)
...lij/plugin/core/properties/PropertiesVisualizer.kt 78.24% <70.58%> (+0.46%) ⬆️
...3r/bpmn/intellij/plugin/core/state/CurrentState.kt 76.64% <100.00%> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@valb3r valb3r merged commit 99106b9 into master Jul 2, 2023
2 checks passed
@valb3r valb3r deleted the feature/FBP-289-unique-id-validation branch July 2, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation of ID uniqueness
2 participants