Skip to content

Conversation

@404Wolf
Copy link
Collaborator

@404Wolf 404Wolf commented Aug 27, 2025

No description provided.

@404Wolf
Copy link
Collaborator Author

404Wolf commented Sep 8, 2025

@tmcw could I get review on this? This will make it easier to support multi file rename, since we'll be able to just implement a unified callback on our end to do the mutations without having to pass it in all the necessary places.

@404Wolf 404Wolf requested a review from tmcw September 8, 2025 20:08
Copy link
Member

@tmcw tmcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tmcw
Copy link
Member

tmcw commented Sep 8, 2025

Looks good - needs to resolve the conflict, and if we want this to contribute to the changelog, would recommend rebasing or merging in main, installing, running npx @changesets/cli to generate a changeset.

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2025

🦋 Changeset detected

Latest commit: fc7f221

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@valtown/codemirror-ls Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@404Wolf 404Wolf merged commit 257529a into main Sep 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants