Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message signing #211

Merged
merged 31 commits into from
Jun 3, 2024
Merged

Message signing #211

merged 31 commits into from
Jun 3, 2024

Conversation

janmazak
Copy link
Collaborator

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

@janmazak janmazak changed the title Msg signing Message signing Feb 12, 2024
@janmazak janmazak changed the base branch from develop to conway February 12, 2024 22:33
@janmazak janmazak force-pushed the msg-signing branch 2 times, most recently from bbd680f to 0c5d7fa Compare February 14, 2024 22:08
@janmazak
Copy link
Collaborator Author

Hash should be displayed always (even if msg is not hashed), I'll have to do it yet.

@janmazak
Copy link
Collaborator Author

Hash displayed now.

The fuzzer does not work yet, it needs a new harness for the new signMsg call.

davidmisiak
davidmisiak reviewed Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@davidmisiak davidmisiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if I should do some manual tests.

src/uiScreens_bagl.c Outdated Show resolved Hide resolved
src/signMsg_ui.c Outdated Show resolved Hide resolved
src/signMsg.c Outdated Show resolved Hide resolved
src/signMsg.c Outdated Show resolved Hide resolved
src/signMsg.c Show resolved Hide resolved
src/signMsg_ui.c Show resolved Hide resolved
@janmazak janmazak force-pushed the msg-signing branch 2 times, most recently from caf2950 to 9639137 Compare February 19, 2024 15:52
@janmazak janmazak force-pushed the msg-signing branch 4 times, most recently from 71fd559 to 05433eb Compare February 20, 2024 14:01
@janmazak
Copy link
Collaborator Author

Signatures passed verification by M. Lang.

@janmazak janmazak marked this pull request as ready for review February 20, 2024 14:03
davidmisiak
davidmisiak approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@davidmisiak davidmisiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted no more issues 👍

src/signMsg.c Outdated Show resolved Hide resolved
@janmazak janmazak changed the base branch from conway to develop May 14, 2024 07:11
@janmazak janmazak merged commit 605d709 into develop Jun 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmisiak davidmisiak davidmisiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janmazak @davidmisiak