Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update zxlib #5

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Update zxlib #5

wants to merge 7 commits into from

Conversation

relatko
Copy link
Collaborator

@relatko relatko commented Aug 6, 2024

Update zxlib. Flex almost works

@relatko
New zxlib, no adjusmens
b51a0fc 
this version does not work, it is here just as zxlib changes reference.
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 6, 2024
View reviewed changes
deps/ledger-zxlib/app/ui/view_internal.h
static const char* review_addrvalue = REVIEW_SCREEN_ADDR_VALUE;
static const char* review_keyconfig = "Review";
static const char* review_configvalue = "configuration";
static const char *review_key = REVIEW_SCREEN_TITLE;

Check notice

Code scanning / CodeQL

Unused static variable Note

Static variable review_key is never read.
deps/ledger-zxlib/app/ui/view_internal.h
static const char* review_keyconfig = "Review";
static const char* review_configvalue = "configuration";
static const char *review_key = REVIEW_SCREEN_TITLE;
static const char *review_txvalue = REVIEW_SCREEN_TXN_VALUE;

Check notice

Code scanning / CodeQL

Unused static variable Note

Static variable review_txvalue is never read.
deps/ledger-zxlib/app/ui/view_internal.h
static const char* review_configvalue = "configuration";
static const char *review_key = REVIEW_SCREEN_TITLE;
static const char *review_txvalue = REVIEW_SCREEN_TXN_VALUE;
static const char *review_addrvalue = REVIEW_SCREEN_ADDR_VALUE;

Check notice

Code scanning / CodeQL

Unused static variable Note

Static variable review_addrvalue is never read.
deps/ledger-zxlib/app/ui/view_internal.h
static const char *review_key = REVIEW_SCREEN_TITLE;
static const char *review_txvalue = REVIEW_SCREEN_TXN_VALUE;
static const char *review_addrvalue = REVIEW_SCREEN_ADDR_VALUE;
static const char *review_keyconfig = "Review";

Check notice

Code scanning / CodeQL

Unused static variable Note

Static variable review_keyconfig is never read.
deps/ledger-zxlib/app/ui/view_internal.h
static const char *review_txvalue = REVIEW_SCREEN_TXN_VALUE;
static const char *review_addrvalue = REVIEW_SCREEN_ADDR_VALUE;
static const char *review_keyconfig = "Review";
static const char *review_configvalue = "configuration";

Check notice

Code scanning / CodeQL

Unused static variable Note

Static variable review_configvalue is never read.
deps/ledger-zxlib/app/ui/view_internal.h
#define INTRO_PAGES 0
#endif

// FIXME: Wait to be fixed on SDK:

Check notice

Code scanning / CodeQL

FIXME comment Note

FIXME comment: Wait to be fixed on SDK:
deps/ledger-zxlib/app/ui/view_nano.c
@@ -85,7 +84,11 @@
}

// passed page count, go to next index
if (viewdata.itemCount > 0 && viewdata.itemIdx < (viewdata.itemCount - 1 + INCLUDE_ACTIONS_COUNT)) {
uint8_t extraScreens = INCLUDE_ACTIONS_COUNT;
if (review_type == REVIEW_MSG && extraScreens > 0) {

Check warning

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always false because extraScreens <= 0.
deps/ledger-zxlib/app/ui/view_nano.c
@@ -104,7 +107,11 @@
}

// passed page count, go to next index
if (viewdata.itemCount > 0 && viewdata.itemIdx < (viewdata.itemCount - 1 + INCLUDE_ACTIONS_COUNT)) {
uint8_t extraScreens = INCLUDE_ACTIONS_COUNT;
if (review_type == REVIEW_MSG && extraScreens > 0) {

Check warning

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always false because extraScreens <= 0.
deps/ledger-zxlib/app/ui/view_x.c
@@ -183,6 +185,11 @@
//////////////////////////
//////////////////////////

static void h_view_address() {
handleMenuShowAddress();
// view_review_show_impl();

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
deps/ledger-zxlib/src/timeutils.c
@@ -465,7 +697,10 @@
// Look up tm_year
date->tm_year = 0;
const uint16_t yearLookupSize = sizeof(yearLookup)/sizeof(yearLookup[0]);
while (date->tm_year < yearLookupSize && yearLookup[date->tm_year] <= time) date->tm_year++;
while (date->tm_year < yearLookupSize && yearLookup[date->tm_year] <= time) {
date->tm_year++;

Check warning

Code scanning / CodeQL

Year field changed using an arithmetic operation without checking for leap year Warning

Field
tm_year
Loading
on variable
date
Loading
has been modified, but no appropriate check for LeapYear was found.
@relatko relatko force-pushed the update-zxlib branch 2 times, most recently from f33465a to 28e1712 Compare August 6, 2024 20:49
cedelavergne-ledger
cedelavergne-ledger reviewed Sep 6, 2024
View reviewed changes
deps/README.md Outdated
@@ -0,0 +1,10 @@
## Updating zx-lib

Menu feaure requires us o change zxlib menu layout. Thus insead of a submodule, we have ledger-zxlib included as a copy. In case you need to update zxlib, this is the list of changes performed.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo:
Menu feature requires us to... instead

And below:
Menu contains

@relatko
Update zxlib and fix typos
ccaf8b7 
Fixes an issue on stax on screens containing 6 entries.
@relatko relatko force-pushed the update-zxlib branch 2 times, most recently from 69c3416 to b39923a Compare September 27, 2024 13:32
@relatko
Python client refactor
3c37d15 
Fixed too many arguments CI issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedelavergne-ledger cedelavergne-ledger cedelavergne-ledger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@relatko @cedelavergne-ledger