Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(binder): make sure default value is read correctly #3116

Closed
wants to merge 1 commit into from

Make sure default value is read correctly

5a479ec
Select commit
Loading
Failed to load commit list.
Closed

fix(binder): make sure default value is read correctly #3116

Make sure default value is read correctly
5a479ec
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 3, 2025 in 0s

92.54% (-0.04%) compared to 3bb8032

View this Pull Request on Codecov

92.54% (-0.04%) compared to 3bb8032

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.54%. Comparing base (3bb8032) to head (5a479ec).

Files with missing lines Patch % Lines
packages/ts/lit-form/src/BinderNode.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3116      +/-   ##
==========================================
- Coverage   92.57%   92.54%   -0.04%     
==========================================
  Files          85       85              
  Lines        3164     3164              
  Branches      775      776       +1     
==========================================
- Hits         2929     2928       -1     
  Misses        183      183              
- Partials       52       53       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov