Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add error message parameter to onError callback in subscription #2987

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cromoteca
Copy link
Contributor

Closes #2062.

@cromoteca cromoteca changed the title feat; add error message parameter to onError callback in subscription feat: add error message parameter to onError callback in subscription Dec 10, 2024
Copy link

sonarcloud bot commented Dec 10, 2024

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (dfc0bca) to head (2ff8fe1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2987   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files          84       84           
  Lines        3159     3159           
  Branches      770      770           
=======================================
  Hits         2923     2923           
  Misses        184      184           
  Partials       52       52           
Flag Coverage Δ
unittests 92.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@taefi taefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, this is a nice enhancement, but, isn't it automatically expose some unwanted error messages to the client as well? For instance, when an endpoint method returning a Signal is annotated with @RolesAllowed("ADMIN"), so far, the only thing on client was: "Error in flux ...", and I wonder if this change exposes the the "access denied" error message to the client, and cause a security issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include the error in the onError callback of Subscription
3 participants