fix: accept null values as valid for positive/negative validators #2986
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2986 +/- ##
=======================================
Coverage 92.56% 92.56%
=======================================
Files 84 84
Lines 3160 3162 +2
Branches 772 776 +4
=======================================
+ Hits 2925 2927 +2
Misses 183 183
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
taefi
changed the title
Lodin
requested changes
Dec 11, 2024
Lodin
approved these changes
Dec 11, 2024
…t-make-ts-fields-not-nullable
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses behavior of
Positive,Negative,PositiveOrZero, andNegativeOrZero, which should accept null values as valid.As API translates null to
NaN, it should be accepted here.Fixes #2826.