fix(file-router): allow routes with the same path (#2971) (CP: 24.6) #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor(file-router): attempt to consider all routes with the same path * refactor(file-router): allow elements with same path in the route list * style(file-router): cleanup * chore: update package-lock.json * test(file-router): fix index fallback assertion * chore: revert package-lock.json * chore(file-router): remove extra dependency * chore(generator-utils): remove unnecessary export * chore: revert package-lock.json * chore(file-router): do not bring old tests back --------- Co-authored-by: Anton Platonov <[email protected]>
ZheSun88
requested review from
platosha and
Lodin
and removed request for
platosha
platosha
changed the title
|
platosha
approved these changes
Dec 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 24.6 #2979 +/- ##
==========================================
- Coverage 92.71% 92.62% -0.09%
==========================================
Files 84 84
Lines 3156 3159 +3
Branches 769 770 +1
==========================================
Hits 2926 2926
- Misses 179 182 +3
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(file-router): attempt to consider all routes with the same path
refactor(file-router): allow elements with same path in the route list
style(file-router): cleanup
chore: update package-lock.json
test(file-router): fix index fallback assertion
chore: revert package-lock.json
chore(file-router): remove extra dependency
chore(generator-utils): remove unnecessary export
chore: revert package-lock.json
chore(file-router): do not bring old tests back