Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make file route HMR work on Windows #2978

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Dec 10, 2024

Fixes #2964

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (0a72e18) to head (b51d044).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2978   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files          84       84           
  Lines        3159     3159           
  Branches      770      770           
=======================================
  Hits         2923     2923           
  Misses        184      184           
  Partials       52       52           
Flag Coverage Δ
unittests 92.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Artur- Artur- requested review from platosha and Lodin December 10, 2024 13:10
Copy link

sonarcloud bot commented Dec 10, 2024

@Artur- Artur- enabled auto-merge (squash) December 10, 2024 13:17
@Artur- Artur- merged commit dfc0bca into main Dec 10, 2024
15 checks passed
@Artur- Artur- deleted the file-router-hmr-windows branch December 10, 2024 13:23
vaadin-bot pushed a commit that referenced this pull request Dec 10, 2024
vaadin-bot pushed a commit that referenced this pull request Dec 10, 2024
vaadin-bot pushed a commit that referenced this pull request Dec 10, 2024
Artur- pushed a commit that referenced this pull request Dec 10, 2024
fix: Make file route HMR work on Windows (#2978)

Fixes #2964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR not working when specify more than one export in file routing
3 participants