Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump remaining 24.6 versions to 24.7 #2968

Merged
merged 9 commits into from
Dec 10, 2024

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Dec 9, 2024

Upgrading react-components to 24.7 alpha needs a release from components, and will be done separately.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.61%. Comparing base (33efa09) to head (5b0527e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2968   +/-   ##
=======================================
  Coverage   92.61%   92.61%           
=======================================
  Files          84       84           
  Lines        3156     3156           
  Branches      769      769           
=======================================
  Hits         2923     2923           
  Misses        181      181           
  Partials       52       52           
Flag Coverage Δ
unittests 92.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taefi taefi marked this pull request as draft December 9, 2024 14:00
@taefi taefi added the hilla Issues related to Hilla label Dec 9, 2024
Copy link
Contributor

@cromoteca cromoteca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd avoid making those changes in package.json files, as they should come from the automatic PRs.

@taefi
Copy link
Contributor Author

taefi commented Dec 9, 2024

I'd avoid making those changes in package.json files, as they should come from the automatic PRs.

I've reverted the unnecessary components version upgrades, and only upgraded some weirdly not-upgraded deps such as @vaadin/bundles (some of the are upgraded, some are not). The rest, I'm updating them intentionally, to make sure, some tests are not passing just by pointing to old version accidentally. Also, there are projects such as endpoints-maven-engine or tests/spring/native that are not being upgraded automatically, as they're not included in the root pom.xml.

@taefi taefi marked this pull request as ready for review December 9, 2024 16:43
Copy link

sonarcloud bot commented Dec 9, 2024

@Artur- Artur- merged commit 73467c8 into main Dec 10, 2024
15 checks passed
@Artur- Artur- deleted the taefi/bump-remaining-24.6-to-24.7 branch December 10, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hilla Issues related to Hilla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants