Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Opt-in React Router v7 features (#2929) (CP: 24.5) #2967

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

mshabarov
Copy link
Contributor

Preparations for React Router v7, opts-in the new features to avoid warnings in console.

Related-to vaadin/flow#20527

* chore: Opt-in React Router v7 features

Preparations for React Router v7, opts-in the new features to avoid warnings in console.

Related-to vaadin/flow#20527

* fix test

---------

Co-authored-by: Vlad Rindevich <[email protected]>
@mshabarov mshabarov requested a review from Lodin December 9, 2024 11:08
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (24.5@4cc8097). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             24.5    #2967   +/-   ##
=======================================
  Coverage        ?   92.09%           
=======================================
  Files           ?       81           
  Lines           ?     2681           
  Branches        ?      699           
=======================================
  Hits            ?     2469           
  Misses          ?      164           
  Partials        ?       48           
Flag Coverage Δ
unittests 92.09% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mshabarov
Copy link
Contributor Author

mshabarov commented Dec 10, 2024

The validation fails because of

npm error While resolving: undefined@undefined
npm error Found: [email protected]
npm error node_modules/react
npm error   peer react@"^18" from @vaadin/[email protected]
npm error   node_modules/@vaadin/hilla-react-auth
npm error     @vaadin/hilla-react-auth@"file:../../{hilla-home}/hilla/packages/ts/react-auth" from the root project
npm error   peer react@">=16.8" from [email protected]
npm error   node_modules/react-router-dom
npm error     peer react-router-dom@"^6.28.0" from @vaadin/[email protected]
npm error     node_modules/@vaadin/hilla-react-auth
npm error       @vaadin/hilla-react-auth@"file:../../{hilla-home}/hilla/packages/ts/react-auth" from the root project
npm error
npm error Could not resolve dependency:
npm error peer react@"^19.0.0" from [email protected]
npm error node_modules/react-dom
npm error   peer react-dom@">=16.8" from [email protected]
npm error   node_modules/react-router-dom
npm error     peer react-router-dom@"^6.28.0" from @vaadin/[email protected]
npm error     node_modules/@vaadin/hilla-react-auth
npm error       @vaadin/hilla-react-auth@"file:../../{hilla-home}/hilla/packages/ts/react-auth" from the root project

which is probable unrelated to the change.

UPD: doesn't happen anymore.

@Lodin Lodin enabled auto-merge (squash) December 11, 2024 17:00
Copy link

sonarcloud bot commented Dec 11, 2024

@Lodin Lodin merged commit 4ec4f1e into 24.5 Dec 11, 2024
15 checks passed
@Lodin Lodin deleted the react-router-flags branch December 11, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants