Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Make build and test work again #2965

Merged
merged 1 commit into from
Dec 6, 2024
Merged

test: Make build and test work again #2965

merged 1 commit into from
Dec 6, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Dec 6, 2024

No description provided.

@Artur- Artur- changed the title test: Make test work again test: Make build and test work again Dec 6, 2024
Copy link

sonarqubecloud bot commented Dec 6, 2024

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.71%. Comparing base (2f4bf98) to head (026a875).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2965   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files          84       84           
  Lines        3156     3156           
  Branches      769      769           
=======================================
  Hits         2926     2926           
  Misses        179      179           
  Partials       51       51           
Flag Coverage Δ
unittests 92.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lodin Lodin merged commit 9e1c08c into main Dec 6, 2024
15 checks passed
@Lodin Lodin deleted the make-build-work branch December 6, 2024 20:26
@vaadin-bot
Copy link
Collaborator

Hi @Artur- and @Lodin, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 9e1c08c
error: could not apply 9e1c08c... test: Make build and test work again (#2965)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@ZheSun88
Copy link
Contributor

CP 24.4 #2973

ZheSun88 pushed a commit that referenced this pull request Dec 10, 2024
test: Make build and test work again (#2965)

Co-authored-by: Artur <[email protected]>
ZheSun88 added a commit that referenced this pull request Dec 17, 2024
* test:Make build and test work again (#2965) (CP:24.4)

* Fix

---------

Co-authored-by: Artur Signell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants