Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump to 24.7-SNAPSHOT #2960

Merged
merged 3 commits into from
Dec 9, 2024
Merged

chore: Bump to 24.7-SNAPSHOT #2960

merged 3 commits into from
Dec 9, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Dec 6, 2024

No description provided.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.71%. Comparing base (72bcc04) to head (77bca6d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2960   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files          84       84           
  Lines        3156     3156           
  Branches      769      769           
=======================================
  Hits         2926     2926           
  Misses        179      179           
  Partials       51       51           
Flag Coverage Δ
unittests 92.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@taefi taefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the Flow version, I'd suggest to also update the npm versions to 24.7.0-alpha0 (similar to what we did for 24.6) so that it doesn't just work by pulling in the old versions unintentionally.

@@ -25,7 +25,7 @@ import org.junit.Before
*/
abstract class AbstractGradleTest {

val hillaVersion = System.getenv("hilla.version").takeUnless { it.isNullOrEmpty() } ?: "24.6-SNAPSHOT"
val hillaVersion = System.getenv("hilla.version").takeUnless { it.isNullOrEmpty() } ?: "24.7-SNAPSHOT"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that flow shouldn't be updated to 24.7-SNAPSHOT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but it is not related to this PR. It has some issues as you can see in #2961

@@ -1,4 +1,4 @@
org.gradle.daemon=false
hillaVersion=24.6-SNAPSHOT
hillaVersion=24.7-SNAPSHOT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that flow shouldn't be updated to 24.7-SNAPSHOT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but it is not related to this PR. It has some issues as you can see in #2961

@ZheSun88
Copy link
Contributor

ZheSun88 commented Dec 9, 2024

can you make the necessary changes @taefi

@Artur-
Copy link
Member Author

Artur- commented Dec 9, 2024

Feel free to update the npm versions, in this PR or a separate one

@taefi
Copy link
Contributor

taefi commented Dec 9, 2024

can you make the necessary changes @taefi

I can, but it has to wait until I'm done with another build failure.

@Artur-
Copy link
Member Author

Artur- commented Dec 9, 2024

This does not break anything so why don't we merge this first, before some other PR cause conflicts with this?

@Artur-
Copy link
Member Author

Artur- commented Dec 9, 2024

If it is only about running npm version 24.7.0-alpha0 in each folder, I can do that..

@Artur-
Copy link
Member Author

Artur- commented Dec 9, 2024

Updated, let's see what happens..

@Artur- Artur- requested a review from taefi December 9, 2024 11:02
@Artur- Artur- enabled auto-merge (squash) December 9, 2024 12:12
Copy link

sonarcloud bot commented Dec 9, 2024

@Artur- Artur- merged commit 1ff7094 into main Dec 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants