-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump to 24.7-SNAPSHOT #2960
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2960 +/- ##
=======================================
Coverage 92.71% 92.71%
=======================================
Files 84 84
Lines 3156 3156
Branches 769 769
=======================================
Hits 2926 2926
Misses 179 179
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the Flow version, I'd suggest to also update the npm versions to 24.7.0-alpha0 (similar to what we did for 24.6) so that it doesn't just work by pulling in the old versions unintentionally.
@@ -25,7 +25,7 @@ import org.junit.Before | |||
*/ | |||
abstract class AbstractGradleTest { | |||
|
|||
val hillaVersion = System.getenv("hilla.version").takeUnless { it.isNullOrEmpty() } ?: "24.6-SNAPSHOT" | |||
val hillaVersion = System.getenv("hilla.version").takeUnless { it.isNullOrEmpty() } ?: "24.7-SNAPSHOT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason that flow shouldn't be updated to 24.7-SNAPSHOT
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but it is not related to this PR. It has some issues as you can see in #2961
@@ -1,4 +1,4 @@ | |||
org.gradle.daemon=false | |||
hillaVersion=24.6-SNAPSHOT | |||
hillaVersion=24.7-SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason that flow shouldn't be updated to 24.7-SNAPSHOT
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but it is not related to this PR. It has some issues as you can see in #2961
can you make the necessary changes @taefi |
Feel free to update the npm versions, in this PR or a separate one |
I can, but it has to wait until I'm done with another build failure. |
This does not break anything so why don't we merge this first, before some other PR cause conflicts with this? |
If it is only about running |
Updated, let's see what happens.. |
Quality Gate passedIssues Measures |
No description provided.