Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow dynamically import atmosphere.js for SW context #2901

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Merge branch 'main' into fix/sw-context-dynamic-import

e38ae3e
Select commit
Loading
Failed to load commit list.
Open

fix: allow dynamically import atmosphere.js for SW context #2901

Merge branch 'main' into fix/sw-context-dynamic-import
e38ae3e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 12, 2024 in 0s

78.70% (-13.87%) compared to 3d07524

View this Pull Request on Codecov

78.70% (-13.87%) compared to 3d07524

Details

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.70%. Comparing base (3d07524) to head (e38ae3e).

Files with missing lines Patch % Lines
packages/ts/frontend/src/FluxConnection.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2901       +/-   ##
===========================================
- Coverage   92.56%   78.70%   -13.87%     
===========================================
  Files          84       83        -1     
  Lines        3160     3094       -66     
  Branches      772      756       -16     
===========================================
- Hits         2925     2435      -490     
- Misses        183      623      +440     
+ Partials       52       36       -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.