feat!(generator): load endpoints from Spring components and stop using Maven/Gradle at each generation #2616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cromoteca
force-pushed
the
feat/avoid-running-maven
branch
4 times, most recently
from
30c2e88 to
236efd5
Compare
cromoteca
force-pushed
the
feat/avoid-running-maven
branch
from
9d4988c to
a917323
Compare
cromoteca
force-pushed
the
feat/avoid-running-maven
branch
from
d7e3b47 to
4023bde
Compare
taefi
reviewed
Dec 19, 2024
packages/java/engine-core/src/main/java/com/vaadin/hilla/engine/EngineConfiguration.java
Outdated
Show resolved
Hide resolved
...ges/java/gradle-plugin/src/main/kotlin/com/vaadin/hilla/gradle/plugin/EngineConfigureTask.kt
Outdated
Show resolved
Hide resolved
...ges/java/gradle-plugin/src/main/kotlin/com/vaadin/hilla/gradle/plugin/EngineConfigureTask.kt
Outdated
Show resolved
Hide resolved
taefi
requested changes
Dec 20, 2024
packages/java/engine-core/src/main/java/com/vaadin/hilla/engine/EngineConfiguration.java
Show resolved
Hide resolved
packages/java/engine-core/src/main/java/com/vaadin/hilla/engine/EngineConfiguration.java
Outdated
Show resolved
Hide resolved
...ages/java/gradle-plugin/src/main/kotlin/com/vaadin/hilla/gradle/plugin/EngineGenerateTask.kt
Outdated
Show resolved
Hide resolved
|
taefi
approved these changes
Dec 23, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the need of calling Maven (or Gradle) at each code generation during development.
Endpoints are now searched between the available Spring Beans. When building for production mode, since the application is not running, some code provided by Spring is run to be able to get a list of beans as if the application was running.
The generator configuration through Maven is no longer possible, since the application can be run directly as a main class. The idea is to provide it as a singleton, which should become a Spring bean. At the moment, it's just an ordinary class and cannot be configured externally, but since that's internal code, the change can happen in future, when some configuration means has been chosen.
Closes #3008
Closes #2626
Closes #2464
Closes #2336
Closes #1161
Closes #1108
Closes #994
Closes #979
Closes #545