Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(models): implement Object Models proposal #2535

Merged
merged 26 commits into from
Jul 17, 2024
Merged

feat(models): implement Object Models proposal #2535

merged 26 commits into from
Jul 17, 2024

Conversation

Lodin
Copy link
Contributor

@Lodin Lodin commented Jun 11, 2024

Resolves #1903

@Lodin Lodin added the hilla Issues related to Hilla label Jun 11, 2024
@Lodin Lodin marked this pull request as ready for review June 19, 2024 15:47
@codecov Codecov
Copy link

codecov bot commented Jun 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (abdd44a) to head (a8ae06b).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2535      +/-   ##
==========================================
+ Coverage   92.65%   92.76%   +0.10%     
==========================================
  Files          66       69       +3     
  Lines        2206     2239      +33     
  Branches      577      587      +10     
==========================================
+ Hits         2044     2077      +33     
  Misses        117      117              
  Partials       45       45
Flag Coverage Δ
unittests 92.76% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lodin Lodin requested a review from platosha June 26, 2024 07:30
@Lodin Lodin changed the title feat(form-models): implement Object Models proposal feat(models): implement Object Models proposal Jul 8, 2024
@Lodin Lodin requested a review from cromoteca July 8, 2024 09:29
cromoteca
cromoteca requested changes Jul 9, 2024
View reviewed changes
packages/ts/models/README.md Outdated Show resolved Hide resolved
packages/ts/models/package.json Outdated Show resolved Hide resolved
packages/ts/models/package.json Outdated Show resolved Hide resolved
packages/ts/models/src/core.ts Show resolved Hide resolved
packages/ts/models/src/model.ts Show resolved Hide resolved
packages/ts/models/src/model.ts Outdated Show resolved Hide resolved
packages/ts/models/src/model.ts Outdated Show resolved Hide resolved
packages/ts/models/src/builders.ts Show resolved Hide resolved
packages/ts/models/src/builders.ts Show resolved Hide resolved
packages/ts/models/src/builders.ts Show resolved Hide resolved
cromoteca
cromoteca requested changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@cromoteca cromoteca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure all exported items have a TSDoc

@Lodin Lodin requested a review from cromoteca July 15, 2024 13:35
@Lodin Lodin requested a review from cromoteca July 16, 2024 09:29
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 16, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Lodin Lodin enabled auto-merge (squash) July 16, 2024 09:55
@Lodin Lodin merged commit 54959d0 into main Jul 17, 2024
16 checks passed
@Lodin Lodin deleted the feat/form-models branch July 17, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platosha platosha Awaiting requested review from platosha

@cromoteca cromoteca Awaiting requested review from cromoteca

Assignees
No one assigned
Labels
hilla Issues related to Hilla
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Object based data models
2 participants
@Lodin @cromoteca