Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: request full-reload only when file-routes.json is added/changed #2289

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Apr 3, 2024

Description

Request for full-reloads in dev mode to only when file-router's vite-plugin ends up adding/updating the file-routes.json.
Other changes to the frontend/views directory should not result in full-reload.

Fixes: #2277

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@taefi taefi requested a review from Lodin April 3, 2024 12:08
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (bf9054d) to head (d2fe861).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2289      +/-   ##
==========================================
- Coverage   95.38%   95.21%   -0.17%     
==========================================
  Files          65       66       +1     
  Lines        4157     4288     +131     
  Branches      604      609       +5     
==========================================
+ Hits         3965     4083     +118     
- Misses        150      163      +13     
  Partials       42       42              
Flag Coverage Δ
unittests 95.21% <100.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@taefi taefi merged commit 8c51388 into main Apr 3, 2024
14 of 15 checks passed
@taefi taefi deleted the taefi/full-reload-only-when-route-configs-change branch April 3, 2024 14:15
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.4.0.alpha19 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR does not work with 24.4.0.alpha18
3 participants