fix: Ignore non-JSX files in views folder #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Legioth
reviewed
Mar 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2249 +/- ##
=======================================
Coverage 93.77% 93.77%
=======================================
Files 64 64
Lines 1638 1638
Branches 368 368
=======================================
Hits 1536 1536
Misses 67 67
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Tested with the attached project in https://github.com/vaadin/copilot-internal/issues/1197 and the app works as expected now. |
|
platosha
approved these changes
Mar 25, 2024
|
This ticket/PR has been released with Hilla 24.4.0.alpha17 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes .ts and .js from extension list, making them ignored.
Shows a warning message if sees any .ts or .js files in /views.
Changes test files extensions to .tsx and .jsx and adds a couple of .js and .ts files, which shouldn't be processes by the plugin.
Fixes #2248