Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove hilla-*-version.json from hilla artifacts, they are provided by platform #2008

Merged
merged 7 commits into from
Feb 2, 2024

Conversation

manolo
Copy link
Member

@manolo manolo commented Jan 31, 2024

No description provided.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b79fbfa) 95.30% compared to head (2ee49dd) 95.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2008   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files          52       52           
  Lines        3495     3495           
  Branches      527      527           
=======================================
  Hits         3331     3331           
  Misses        129      129           
  Partials       35       35           
Flag Coverage Δ
unittests 95.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manolo manolo force-pushed the remove-json-v2 branch 4 times, most recently from 48dfec4 to 3644c1a Compare February 1, 2024 14:21
@manolo manolo changed the title chore: 2nd approach: remove hilla-*-version.json from hilla artifacts, they are provided by flow chore: remove hilla-*-version.json from hilla artifacts, they are provided by flow Feb 2, 2024
mshabarov
mshabarov previously approved these changes Feb 2, 2024
@manolo manolo marked this pull request as ready for review February 2, 2024 08:17
mshabarov
mshabarov previously approved these changes Feb 2, 2024
@mshabarov mshabarov requested a review from cromoteca February 2, 2024 08:19
@manolo manolo changed the title chore: remove hilla-*-version.json from hilla artifacts, they are provided by flow chore: remove hilla-*-version.json from hilla artifacts, they are provided by platform Feb 2, 2024
@manolo manolo enabled auto-merge (rebase) February 2, 2024 09:39
@manolo manolo disabled auto-merge February 2, 2024 09:39
@manolo manolo enabled auto-merge (squash) February 2, 2024 09:39
@manolo manolo disabled auto-merge February 2, 2024 09:39
Copy link

sonarcloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@manolo manolo enabled auto-merge (squash) February 2, 2024 09:40
@manolo manolo merged commit 4ce65b8 into main Feb 2, 2024
15 checks passed
@manolo manolo deleted the remove-json-v2 branch February 2, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants