chore: align dependency versions with flow/platform 24.4 #2002
Conversation
align with platform 24.4
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2002 +/- ##
=======================================
Coverage 95.30% 95.30%
=======================================
Files 52 52
Lines 3495 3495
Branches 527 527
=======================================
Hits 3331 3331
Misses 129 129
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ZheSun88
changed the title
pom.xml
Outdated
| <swagger.core.version>2.2.20</swagger.core.version> | ||
| <swagger.models.version>2.2.20</swagger.models.version> | ||
| <swagger.parser.v3.version>2.1.15</swagger.parser.v3.version> | ||
| <jackson.version>2.15.3</jackson.version> | ||
| <jackson.version>2.16.0</jackson.version> |
There was a problem hiding this comment.
We have Snyk PRs asking for 2.16.1
There was a problem hiding this comment.
flow has reverted the 2.16.1 vaadin/flow@e6028dd
There was a problem hiding this comment.
there is an issue about the enforcer-plugin. but i dont quite understand why it fail in this way.
Dependency convergence error for com.fasterxml.jackson.datatype:jackson-datatype-jdk8:jar:2.15.3 paths to dependency are:
Error: +-com.vaadin.hilla:parser-jvm-plugin-backbone:jar:24.4-SNAPSHOT
Error: +-com.vaadin.hilla:parser-jvm-utils:jar:24.4-SNAPSHOT:compile
Error: +-com.fasterxml.jackson.datatype:jackson-datatype-jdk8:jar:2.15.3:compile
Error: and
Error: +-com.vaadin.hilla:parser-jvm-plugin-backbone:jar:24.4-SNAPSHOT
Error: +-com.fasterxml.jackson.datatype:jackson-datatype-jdk8:jar:2.16.0:compile
the parser-jvm-utils is a module we build and version used there is from the root of hilla project. where is the 2.15.3 coming.. aww.
There was a problem hiding this comment.
It comes from Swagger. I'll try to align all dependencies.
There was a problem hiding this comment.
Well, Swagger is up to date, so I guess we're not ready to use Jackson 2.16 in Hilla since Swagger itself still doesn't use it.
There was a problem hiding this comment.
okay.. then let us just revert the jackson version update.
This reverts commit 3e0a756.
|
align with platform 24.4