Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gather Flow and Hilla Gradle tasks under vaadin group #1996

Merged
merged 6 commits into from
Feb 1, 2024

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Jan 29, 2024

Description

This gathers all available Gradle tasks from
Hilla and Flow plugins under one task group
"Vaadin". Also, this gets rid of all the
duplicate extension parameters from
EngineProjectExtension.

The EngineProjectExtension instance that
currently being exposed to users as hilla
can remain the same to show which
parameters are related to which set of tasks,
for example, if the users wants to set the
exposedPackagesToParser, that should
be set via hilla extension:

hilla {
    exposedPackagesToParser =["com.example"]
}

vs. setting the productionMode should be done
via vaadin extension:

vaadin {
    productionMode = true
}

Alse need to decide about which prefix to use
for each set of tasks: hilla for Hilla specific
tasks e.g. hillaGenerate vs. vaadin everywhere
e.g. vaadinGenerate, vaadinConfigure, and etc.

Part of vaadin/platform#4945

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (39f662e) 95.30% compared to head (1c05003) 95.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1996   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files          52       52           
  Lines        3496     3496           
  Branches      527      527           
=======================================
  Hits         3332     3332           
  Misses        129      129           
  Partials       35       35           
Flag Coverage Δ
unittests 95.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taefi taefi marked this pull request as ready for review January 31, 2024 14:37
@taefi taefi requested a review from cromoteca January 31, 2024 14:37
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@taefi taefi merged commit ba56124 into main Feb 1, 2024
15 checks passed
@taefi taefi deleted the taefi/unify-gradle-plugin branch February 1, 2024 06:47
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.4.0.alpha3 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants