Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add file-based router #1985

Merged
merged 24 commits into from
Feb 7, 2024
Merged

feat: add file-based router #1985

merged 24 commits into from
Feb 7, 2024

Conversation

Lodin
Copy link
Contributor

@Lodin Lodin commented Jan 24, 2024

Fixes #2024

@Lodin Lodin marked this pull request as ready for review February 5, 2024 08:33
@Lodin
Copy link
Contributor Author

Lodin commented Feb 5, 2024

It looks like the only thing failing is the Codecov service, so we can skip that failure and merge the PR

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (d5a021b) 95.30% compared to head (9fa7b15) 95.26%.

Files Patch % Lines
packages/ts/hilla-file-router/src/runtime/utils.ts 87.61% 12 Missing and 1 partial ⚠️
...file-router/src/vite-plugin/collectRoutesFromFS.ts 95.16% 3 Missing ⚠️
...ile-router/src/vite-plugin/createRoutesFromMeta.ts 96.84% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1985      +/-   ##
==========================================
- Coverage   95.30%   95.26%   -0.05%     
==========================================
  Files          52       57       +5     
  Lines        3495     3863     +368     
  Branches      527      565      +38     
==========================================
+ Hits         3331     3680     +349     
- Misses        129      147      +18     
- Partials       35       36       +1     
Flag Coverage Δ
unittests 95.26% <94.83%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lodin
Copy link
Contributor Author

Lodin commented Feb 6, 2024

Ok, the issue with codecov is resolved. It seems there were some problems with Github Operations.

@Lodin Lodin enabled auto-merge (squash) February 6, 2024 08:36
@Lodin Lodin disabled auto-merge February 6, 2024 09:58
packages/ts/hilla-file-router/src/utils.ts Outdated Show resolved Hide resolved
packages/ts/hilla-file-router/src/utils.ts Outdated Show resolved Hide resolved
packages/ts/hilla-file-router/src/utils.ts Outdated Show resolved Hide resolved
packages/ts/hilla-file-router/src/react.ts Outdated Show resolved Hide resolved
packages/ts/hilla-file-router/src/utils.ts Outdated Show resolved Hide resolved
packages/ts/hilla-file-router/src/generateJson.ts Outdated Show resolved Hide resolved
packages/ts/hilla-file-router/src/generateRoutes.ts Outdated Show resolved Hide resolved
@Lodin Lodin requested a review from taefi February 7, 2024 09:10
@Lodin Lodin requested a review from taefi February 7, 2024 10:00
Copy link
Contributor

@taefi taefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

9 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Lodin Lodin merged commit 302eb0e into main Feb 7, 2024
13 of 15 checks passed
@Lodin Lodin deleted the feat/file-router branch February 7, 2024 13:33
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.4.0.alpha4 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FS routing] filename conventions for views, layouts, and helpers
4 participants