-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add file-based router #1985
Conversation
* resolve issue with non-transpiled TS file during JSON generation. * implement adjusted file naming conventions
It looks like the only thing failing is the Codecov service, so we can skip that failure and merge the PR |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1985 +/- ##
==========================================
- Coverage 95.30% 95.26% -0.05%
==========================================
Files 52 57 +5
Lines 3495 3863 +368
Branches 527 565 +38
==========================================
+ Hits 3331 3680 +349
- Misses 129 147 +18
- Partials 35 36 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ok, the issue with codecov is resolved. It seems there were some problems with Github Operations. |
Co-authored-by: Soroosh Taefi <[email protected]>
* Improve namings * Separate runtime and compile-time code
packages/ts/hilla-file-router/src/vite-plugin/collectRoutesFromFS.ts
Outdated
Show resolved
Hide resolved
packages/ts/hilla-file-router/src/vite-plugin/createRoutesFromFS.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 9 New issues |
This ticket/PR has been released with Hilla 24.4.0.alpha4 and is also targeting the upcoming stable 24.4.0 version. |
Fixes #2024