feat: Add localeSignal() method to UI and VaadinSession #23367
+314
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a read-only signal that reflects the current locale and updates automatically when setLocale() is called. This allows components to reactively respond to locale changes using the signals API.
Legioth
reviewed
Jan 29, 2026
| */ | ||
| private Locale locale = Locale.getDefault(); | ||
|
|
||
| private transient ValueSignal<Locale> localeSignal; |
Member
There was a problem hiding this comment.
This use case involves multiple UIs which according to our rules mean it should be a SharedValueSignal.
Legioth
reviewed
Jan 29, 2026
| @@ -127,6 +129,8 @@ public class UI extends Component | |||
|
|
|||
| private Locale locale = Locale.getDefault(); | |||
Member
There was a problem hiding this comment.
Could we remove this field and always store the value in a signal instead of having two sources of truth?
Test Results1 146 files - 204 1 146 suites - 204 1h 11m 4s ⏱️ - 6m 8s For more details on these failures and errors, see this check. Results for commit 980cb29. ± Comparison against base commit 32fc241. This pull request removes 2231 and adds 12 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
tltv
reviewed
Jan 29, 2026
tltv
reviewed
Feb 2, 2026
- Change return type from Signal to WritableSignal for both UI and VaadinSession - Use SharedValueSignal for VaadinSession (thread-safe for multiple UIs) - Signal becomes source of truth once accessed via localeSignal() - Add effect in UI to notify LocaleChangeObservers on signal changes - Maintain backward compatibility when signals feature is not enabled
The signal now holds the locale value directly instead of mirroring a separate field. For VaadinSession, the locale field is retained only for serialization since SharedValueSignal is transient.
Document that writing directly to the signal does not trigger LocaleChangeObservers (UI) or propagate to UIs (VaadinSession).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a signal that reflects the current locale and updates automatically when setLocale() is called. This allows components to reactively respond to locale changes using the signals API.